feat: basic escaping support #713
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motdotla
force-pushed
the
master
branch
4 times, most recently
from
01fa9ef
to
ef48935
Compare
motdotla
reviewed
Feb 6, 2024
| @@ -23,9 +23,9 @@ t.equal(parsed.DOUBLE_QUOTES_SPACED, ' double quotes ', 'respects surround | |||
|
|
|||
| t.equal(parsed.EXPAND_NEWLINES, 'expand\nnew\nlines', 'expands newlines but only if double quoted') | |||
|
|
|||
| t.equal(parsed.DONT_EXPAND_UNQUOTED, 'dontexpand\\nnewlines', 'expands newlines but only if double quoted') | |||
| t.equal(parsed.DONT_EXPAND_UNQUOTED, 'dontexpandnnewlines', 'expands newlines but only if double quoted') | |||
There was a problem hiding this comment.
i have mixed feelings on this behavior. looks like the rubygem has done this since inception, but it doesn't follow the principle of least surprise to me. the \n disappearing would frustrate me.
There was a problem hiding this comment.
this behavior goes back to 0.0.3. 599144a
i'm open to arguments for doing this, but it will definitely be a potentially significant breaking change if we do
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements basic escaping support as implemented in the Ruby Gem
I have attempted to align the code style / logic components with the Ruby Gem.
Based on the assumption that this is the "source of truth" (pseudo spec) for this library.
I personally think other implementations of dotenv have more complete (better?) support for escaping and
expanding special characters (Example Spec).
But I wanted to start with the minimal viable scope and avoid misalignment with the "source of truth" (?)
resolves #711